[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=854976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854976
]
ASF GitHub Bot logged work on HIVE-26809:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/23 09:03
Start Date: 05/Apr/23 09:03
Worklog Time Spent: 10m
Work Description: abstractdog commented on code in PR #4121:
URL: https://github.com/apache/hive/pull/4121#discussion_r1158237604
##########
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java:
##########
@@ -1234,7 +1234,7 @@ public void emptyFile() throws Exception {
assertEquals(false, reader.rows().hasNext());
assertEquals(CompressionKind.NONE, reader.getCompression());
assertEquals(0, reader.getNumberOfRows());
- assertEquals(0, reader.getCompressionSize());
+ assertEquals(262144, reader.getCompressionSize());
Review Comment:
yay, very cool, nice catch!
so we had previously made a completely invalid assertion without a code
comment (without being aware that we're asserting based on an invalid behavior)
Issue Time Tracking
-------------------
Worklog Id: (was: 854976)
Time Spent: 12h (was: 11h 50m)
> Upgrade ORC to 1.8.3
> --------------------
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0
> Reporter: Dmitriy Fingerman
> Assignee: Zoltán Rátkai
> Priority: Major
> Labels: pull-request-available
> Time Spent: 12h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
