[
https://issues.apache.org/jira/browse/HIVE-27020?focusedWorklogId=855760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-855760
]
ASF GitHub Bot logged work on HIVE-27020:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/23 10:51
Start Date: 10/Apr/23 10:51
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4091:
URL: https://github.com/apache/hive/pull/4091#discussion_r1161629018
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java:
##########
@@ -61,12 +60,10 @@ public void init(AtomicBoolean stop) throws Exception {
cleanerExecutor = CompactorUtil.createExecutorWithThreadFactory(
conf.getIntVar(HiveConf.ConfVars.HIVE_COMPACTOR_CLEANER_THREADS_NUM),
COMPACTOR_CLEANER_THREAD_NAME_FORMAT);
- if (CollectionUtils.isEmpty(cleanupHandlers)) {
- FSRemover fsRemover = new FSRemover(conf,
ReplChangeManager.getInstance(conf), metadataCache);
- cleanupHandlers = TaskHandlerFactory.getInstance()
- .getHandlers(conf, txnHandler, metadataCache,
- metricsEnabled, fsRemover);
- }
+ FSRemover fsRemover = new FSRemover(conf,
ReplChangeManager.getInstance(conf), metadataCache);
+ cleanupHandlers = TaskHandlerFactory.getInstance()
+ .getHandlers(conf, txnHandler, metadataCache,
+ metricsEnabled, fsRemover);
Review Comment:
could we move this to above line
Issue Time Tracking
-------------------
Worklog Id: (was: 855760)
Time Spent: 6.5h (was: 6h 20m)
> Implement a separate handler to handle aborted transaction cleanup
> ------------------------------------------------------------------
>
> Key: HIVE-27020
> URL: https://issues.apache.org/jira/browse/HIVE-27020
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> As described in the parent task, once the cleaner is separated into different
> entities, implement a separate handler which can create requests for aborted
> transactions cleanup. This would move the aborted transaction cleanup
> exclusively to the cleaner.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
