[
https://issues.apache.org/jira/browse/HIVE-27150?focusedWorklogId=855970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-855970
]
ASF GitHub Bot logged work on HIVE-27150:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/23 22:39
Start Date: 10/Apr/23 22:39
Worklog Time Spent: 10m
Work Description: saihemanth-cloudera commented on code in PR #4123:
URL: https://github.com/apache/hive/pull/4123#discussion_r1162143358
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -5026,20 +5026,18 @@ private boolean drop_partition_common(RawStore ms,
String catName, String db_nam
verifyIsWritablePath(partPath);
}
- if (!ms.dropPartition(catName, db_name, tbl_name, part_vals)) {
- throw new MetaException("Unable to drop partition");
- } else {
- if (!transactionalListeners.isEmpty()) {
+ String partName = Warehouse.makePartName(tbl.getPartitionKeys(),
part_vals);
+ ms.dropPartition(catName, db_name, tbl_name, partName);
Review Comment:
If dropPartition in the object store is not successful, then we should throw
a meta exception, right?
Issue Time Tracking
-------------------
Worklog Id: (was: 855970)
Time Spent: 4.5h (was: 4h 20m)
> Drop single partition can also support direct sql
> -------------------------------------------------
>
> Key: HIVE-27150
> URL: https://issues.apache.org/jira/browse/HIVE-27150
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: Wechar
> Assignee: Wechar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> *Background:*
> [HIVE-6980|https://issues.apache.org/jira/browse/HIVE-6980] supports direct
> sql for drop_partitions, we can reuse this huge improvement in drop_partition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
