[
https://issues.apache.org/jira/browse/HIVE-27158?focusedWorklogId=856661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-856661
]
ASF GitHub Bot logged work on HIVE-27158:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/23 08:05
Start Date: 13/Apr/23 08:05
Worklog Time Spent: 10m
Work Description: InvisibleProgrammer commented on code in PR #4131:
URL: https://github.com/apache/hive/pull/4131#discussion_r1165156528
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2205,9 +2205,8 @@ public static enum ConfVars {
"padding tolerance config (hive.exec.orc.block.padding.tolerance)."),
HIVE_ORC_CODEC_POOL("hive.use.orc.codec.pool", false,
"Whether to use codec pool in ORC. Disable if there are bugs with
codec reuse."),
- HIVE_USE_STATS_FROM("hive.use.stats.from","iceberg","Use stats from
iceberg table snapshot for query " +
- "planning. This has three values metastore, puffin and iceberg"),
-
+ HIVE_ICEBERG_STATS_SOURCE("hive.iceberg.stats.source","iceberg","Use stats
from iceberg " +
Review Comment:
I have found a better way to handle this:
If you check that example, it not only defines the possible values, but also
ensures the casing will be as it is expected. So that, you don't need to call
`toLowerCase()` method when you read the value.
``` java
// setting up execution engine
HIVE_EXECUTION_ENGINE("hive.execution.engine", Runtime.TEZ.toString(),
new StringSet(true, Runtime.MR.toString(),
Runtime.TEZ.toString(),
Runtime.IMPALA.toString()),
// and reading the value
if (HiveConf.getVar(conf,
HiveConf.ConfVars.HIVE_EXECUTION_ENGINE).equals("tez")) {
```
Issue Time Tracking
-------------------
Worklog Id: (was: 856661)
Time Spent: 9h 40m (was: 9.5h)
> Store hive columns stats in puffin files for iceberg tables
> -----------------------------------------------------------
>
> Key: HIVE-27158
> URL: https://issues.apache.org/jira/browse/HIVE-27158
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri Govindappa
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
