[
https://issues.apache.org/jira/browse/HIVE-27284?focusedWorklogId=858515&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858515
]
ASF GitHub Bot logged work on HIVE-27284:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/23 22:07
Start Date: 21/Apr/23 22:07
Worklog Time Spent: 10m
Work Description: wecharyu opened a new pull request, #4257:
URL: https://github.com/apache/hive/pull/4257
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
1. make `HMSHandler` Proxy configurable by new metastore conf
**"metastore.hmshandler.proxy"**
2. provide `AbstractHMSHandlerProxy` to extend customized handler
3. clean some hacked test codes in `HMSHandler`
### Why are the changes needed?
1. make the handler of metastore flexible to config and extend
2. improve the code of `HMSHandler`
### Does this PR introduce _any_ user-facing change?
Yes, user can use new conf and api to extend their own handler.
### How was this patch tested?
Passing all existing tests.
Issue Time Tracking
-------------------
Worklog Id: (was: 858515)
Remaining Estimate: 0h
Time Spent: 10m
> Make HMSHandler proxy pluggable
> -------------------------------
>
> Key: HIVE-27284
> URL: https://issues.apache.org/jira/browse/HIVE-27284
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Affects Versions: 4.0.0-alpha-2
> Reporter: Wechar
> Assignee: Wechar
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently HMS use the only proxy implementation of HMSHandler i.e
> {{RetryingHMSHandler}}, resulting in some code hacks in {{HMSHandler}}. For
> example when test HMS timeout, we add additional static fields
> {{testTimeoutEnabled}} and {{testTimeoutValue}}, and add sleep code in
> {{create_database}} method, which is not elegant and flexible.
> So we introduce a new conf {{metastore.hmshandler.proxy}} to configure proxy
> class for HMSHandler, it will be more convenient to extend the new proxy of
> HMSHandler and can separate test code from HMSHandler.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
