[
https://issues.apache.org/jira/browse/HIVE-27285?focusedWorklogId=858895&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858895
]
ASF GitHub Bot logged work on HIVE-27285:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/23 10:33
Start Date: 25/Apr/23 10:33
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on code in PR #4258:
URL: https://github.com/apache/hive/pull/4258#discussion_r1176324646
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java:
##########
@@ -85,15 +85,13 @@ default List<String> filterCatalogs(List<String> catalogs)
throws MetaException
List<String> filterTableNames(String catName, String dbName, List<String>
tableList)
throws MetaException;
- // Previously this was handled by filterTableNames. But it can't be anymore
because we can no
- // longer depend on a 1-1 mapping between table name and entry in the list.
/**
* Filter a list of TableMeta objects.
* @param tableMetas list of TableMetas to filter
* @return filtered table metas
* @throws MetaException something went wrong
*/
- List<TableMeta> filterTableMetas(String catName,String
dbName,List<TableMeta> tableMetas) throws MetaException;
+ List<TableMeta> filterTableMetas(List<TableMeta> tableMetas) throws
MetaException;
Review Comment:
nit: I'm not sure the right way, perhaps we can mark the original method
DEPRECATED and print WARN message
Issue Time Tracking
-------------------
Worklog Id: (was: 858895)
Time Spent: 1.5h (was: 1h 20m)
> Add TableMeta ownership for filterTableMetas
> --------------------------------------------
>
> Key: HIVE-27285
> URL: https://issues.apache.org/jira/browse/HIVE-27285
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Affects Versions: 4.0.0
> Reporter: John Sherman
> Assignee: John Sherman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently TableMeta does not include ownership information which makes it
> difficult for filterTableMetas to efficiently filter based on ${OWNER}
> privileges.
> We should add ownership information to TableMeta and utilizing it in
> filterTableMetas authorization checks.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
