[
https://issues.apache.org/jira/browse/HIVE-27295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor updated HIVE-27295:
--------------------------------
Description:
1. While waiting for docker container to start properly, we should print the
output of docker logs command in every loop, otherwise we can miss important
information about the actual startup process if the docker container was oom
killed in the meantime. Not to mention the fact that we're currently not
logging the output at all in case of an error:
https://github.com/apache/hive/blob/59058c65457fb7ab9d8575a555034e6633962661/itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/AbstractExternalDB.java#L125-L127
2. We can include the output for docker events in the logs in case of an error
(like: oom killed container), which might contain useful information.
We can have info like this:
{code}
2023-04-25T08:47:08.852515314-07:00 container oom
2ba12cd9cd844bb30b3158564bd68cd97f25e7a05172d111713ac9f7c1c0b1d4
(image=harbor.rke-us-west-04.kc.cloudera.com/docker_private_cache/cloudera_thirdparty/postgres:9.3,
name=qtestExternalDB-PostgresExternalDB)
2023-04-25T08:47:08.893742200-07:00 container die
2ba12cd9cd844bb30b3158564bd68cd97f25e7a05172d111713ac9f7c1c0b1d4 (exitCode=1,
image=harbor.rke-us-west-04.kc.cloudera.com/docker_private_cache/cloudera_thirdparty/postgres:9.3,
name=qtestExternalDB-PostgresExternalDB)
{code}
was:
1. While waiting for docker container to start properly, we should print the
output of docker logs command in every loop, otherwise we can miss important
information about the actual startup process if the docker container was oom
killed in the meantime. Not to mention the fact that we're currently not
logging the output at all in case of an error:
https://github.com/apache/hive/blob/59058c65457fb7ab9d8575a555034e6633962661/itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/AbstractExternalDB.java#L125-L127
2. We can include the output for docker events in the logs in case of an error
(like: oom killed container), which might contain useful information.
We can have info like this:
{code}
2023-04-25T08:47:08.852515314-07:00 container oom
2ba12cd9cd844bb30b3158564bd68cd97f25e7a05172d111713ac9f7c1c0b1d4
(image=harbor.rke-us-west-04.kc.cloudera.com/docker_private_cache/cloudera_thirdparty/postgres:9.3,
name=qtestExternalDB-PostgresExternalDB)
2023-04-25T08:47:08.893742200-07:00 container die
2ba12cd9cd844bb30b3158564bd68cd97f25e7a05172d111713ac9f7c1c0b1d4 (exitCode=1,
image=harbor.rke-us-west-04.kc.cloudera.com/docker_private_cache/cloudera_thirdparty/postgres:9.3,
name=qtestExternalDB-PostgresExternalDB)
{code}
3. Consider adding a [--memory
option|https://docs.docker.com/config/containers/resource_constraints/] to the
docker run command with a reasonable value to make the RDBMS docker image
running process stable and independent from system settings.
> Improve docker logging in AbstractExternalDB
> --------------------------------------------
>
> Key: HIVE-27295
> URL: https://issues.apache.org/jira/browse/HIVE-27295
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> 1. While waiting for docker container to start properly, we should print the
> output of docker logs command in every loop, otherwise we can miss important
> information about the actual startup process if the docker container was oom
> killed in the meantime. Not to mention the fact that we're currently not
> logging the output at all in case of an error:
> https://github.com/apache/hive/blob/59058c65457fb7ab9d8575a555034e6633962661/itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/AbstractExternalDB.java#L125-L127
> 2. We can include the output for docker events in the logs in case of an
> error (like: oom killed container), which might contain useful information.
> We can have info like this:
> {code}
> 2023-04-25T08:47:08.852515314-07:00 container oom
> 2ba12cd9cd844bb30b3158564bd68cd97f25e7a05172d111713ac9f7c1c0b1d4
> (image=harbor.rke-us-west-04.kc.cloudera.com/docker_private_cache/cloudera_thirdparty/postgres:9.3,
> name=qtestExternalDB-PostgresExternalDB)
> 2023-04-25T08:47:08.893742200-07:00 container die
> 2ba12cd9cd844bb30b3158564bd68cd97f25e7a05172d111713ac9f7c1c0b1d4 (exitCode=1,
> image=harbor.rke-us-west-04.kc.cloudera.com/docker_private_cache/cloudera_thirdparty/postgres:9.3,
> name=qtestExternalDB-PostgresExternalDB)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
