[
https://issues.apache.org/jira/browse/HIVE-26659?focusedWorklogId=859528&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859528
]
ASF GitHub Bot logged work on HIVE-26659:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/23 01:21
Start Date: 28/Apr/23 01:21
Worklog Time Spent: 10m
Work Description: amansinha100 commented on code in PR #4190:
URL: https://github.com/apache/hive/pull/4190#discussion_r1179845226
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java:
##########
@@ -556,6 +556,9 @@ public void process(Object row, int tag) throws
HiveException {
}
} else {
storage[pos] = emptyList;
+ if (pos != 0 && condn[pos - 1].getType() == JoinDesc.ANTI_JOIN) {
Review Comment:
Just for reference, this check matches the check that is done in
CommonJoinOperator.checkAndGenObject() here:
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java#L973
. Looks good to me.
Issue Time Tracking
-------------------
Worklog Id: (was: 859528)
Time Spent: 2h (was: 1h 50m)
> TPC-DS query 16, 69, 94 return wrong results.
> ---------------------------------------------
>
> Key: HIVE-26659
> URL: https://issues.apache.org/jira/browse/HIVE-26659
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 4.0.0-alpha-2
> Reporter: Sungwoo Park
> Assignee: Seonggon Namgung
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> TPC-DS query 16, 69, 94 return wrong results when hive.auto.convert.anti.join
> is set to true.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
