[
https://issues.apache.org/jira/browse/HIVE-27277?focusedWorklogId=859613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859613
]
ASF GitHub Bot logged work on HIVE-27277:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/23 11:36
Start Date: 28/Apr/23 11:36
Worklog Time Spent: 10m
Work Description: simhadri-g commented on code in PR #4274:
URL: https://github.com/apache/hive/pull/4274#discussion_r1180027342
##########
.github/workflows/docker-image.yml:
##########
@@ -0,0 +1,38 @@
+name: ci hive docker image
+
+on:
+ push:
+ branches:
+ - "master"
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ steps:
+ -
+ name: Checkout
+ uses: actions/checkout@v3
+ -
+ name: Login to Docker Hub
+ uses: docker/login-action@v2
+ with:
+ username: ${{ secrets.DOCKERHUB_USERNAME }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+ -
+ name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v2
+
+ -
+ name: Build and push
+ uses: docker/build-push-action@v4
+ with:
+ context: ./packaging/src/docker/
+ file: ./packaging/src/docker/Dockerfile
+ push: true
+ tags: ${{ secrets.DOCKERHUB_USERNAME }}/hive:test-image
Review Comment:
> Can we trigger the build for GA automatically?
>https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
Since we are pushing the changes to the dockerhub for the 1st time, we
wanted to trigger it with workflow_dispatcher to verify the dockerhub
integration.
Once we verify that this GH action succeeds, we can set it to trigger
automatically and update all the images on every release or once every three
months.
> I think it makes some troubles every time we should add the new GA build
manually, it adds extra steps for
> releasing the new version, sometimes we may even forget about it.
I agree, but I think for a new GA :
- We will not have prior knowledge of the versions of hive, tez and hadoop
to use in the next GA. (Workaround could be: obtain from pom.xml)
- Someone will have to build the new GA docker images locally and verify if
it's working before we push them to docker hub.
So that is why i was thinking we should retain the manual step at release
time.
Other repos follow something similar:
https://github.com/apache/spark-docker/tree/master/.github/workflows
Issue Time Tracking
-------------------
Worklog Id: (was: 859613)
Time Spent: 2h 40m (was: 2.5h)
> Set up github actions workflow to build and push docker image to docker hub
> ---------------------------------------------------------------------------
>
> Key: HIVE-27277
> URL: https://issues.apache.org/jira/browse/HIVE-27277
> Project: Hive
> Issue Type: Sub-task
> Reporter: Simhadri Govindappa
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
