[
https://issues.apache.org/jira/browse/HIVE-27234?focusedWorklogId=859799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859799
]
ASF GitHub Bot logged work on HIVE-27234:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/23 17:24
Start Date: 29/Apr/23 17:24
Worklog Time Spent: 10m
Work Description: zhangbutao commented on PR #4216:
URL: https://github.com/apache/hive/pull/4216#issuecomment-1528833729
> Thanx @zhangbutao, overall changes looks good, dropped some comments.
>
> Additionally your code ain't formatted according to hive formatting rules,
line length should be less than 120 and other, can refer here:
https://github.com/apache/hive/blob/master/dev-support/eclipse-styles.xml
>
> Additionally add a q test. Where you do an explain of the create branch
statement before creating the branch.
>
> Add some failure test cases: Branch already exist and you try to create a
branch Attempt to create a branch on a non iceberg table
>
> In the positive test case check for the data as well.
I think i have addressed these comments. Please take a look again if you
have time. Thanks @ayushtkn
Issue Time Tracking
-------------------
Worklog Id: (was: 859799)
Time Spent: 4h 10m (was: 4h)
> Iceberg: CREATE BRANCH SQL implementation
> ------------------------------------------
>
> Key: HIVE-27234
> URL: https://issues.apache.org/jira/browse/HIVE-27234
> Project: Hive
> Issue Type: Sub-task
> Components: Iceberg integration
> Reporter: zhangbutao
> Assignee: zhangbutao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Maybe we can follow spark sql about branch ddl implementation
> [https://github.com/apache/iceberg/pull/6617]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
