[
https://issues.apache.org/jira/browse/HIVE-25266?focusedWorklogId=861178&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861178
]
ASF GitHub Bot logged work on HIVE-25266:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/23 10:37
Start Date: 09/May/23 10:37
Worklog Time Spent: 10m
Work Description: rkirtir commented on code in PR #4297:
URL: https://github.com/apache/hive/pull/4297#discussion_r1188462611
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestWarehouseExternalDir.java:
##########
@@ -44,114 +44,94 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
-
+import org.apache.hadoop.hive.metastore.api.Database;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.apache.hadoop.hive.metastore.Warehouse;
-
[email protected]("HIVE-25266")
public class TestWarehouseExternalDir {
- private static final Logger LOG =
LoggerFactory.getLogger(TestWarehouseExternalDir.class);
+ private static final Logger LOG =
LoggerFactory.getLogger(TestWarehouseExternalDir.class);
+
+ private static MiniHS2 miniHS2;
+ private static Hive db;
- static MiniHS2 miniHS2;
- static Hive db;
- static Connection conn;
+ private static HiveConf conf;
+ private static Connection conn;
Review Comment:
Agree.
Removed unnecessary conn creation and closed connection in afterTest() class
Issue Time Tracking
-------------------
Worklog Id: (was: 861178)
Time Spent: 1h 40m (was: 1.5h)
> Fix TestWarehouseExternalDir
> ----------------------------
>
> Key: HIVE-25266
> URL: https://issues.apache.org/jira/browse/HIVE-25266
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> test is unstable
> http://ci.hive.apache.org/job/hive-flaky-check/244/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
