[
https://issues.apache.org/jira/browse/HIVE-27319?focusedWorklogId=861272&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861272
]
ASF GitHub Bot logged work on HIVE-27319:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/23 01:29
Start Date: 10/May/23 01:29
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on code in PR #4299:
URL: https://github.com/apache/hive/pull/4299#discussion_r1189268286
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -7526,7 +7526,10 @@ public List<Partition> get_partitions_by_names(final
String dbName, final String
success = getMS().commitTransaction();
} catch (Exception e) {
ex = e;
- rethrowException(e);
+ throw handleException(e)
+ .throwIfInstance(MetaException.class, NoSuchObjectException.class,
InvalidObjectException.class)
+ .throwIfInstance(TException.class)
Review Comment:
nit: we cannot throw `TException`, as the thrift api doesn't claim it.
Issue Time Tracking
-------------------
Worklog Id: (was: 861272)
Time Spent: 1h 40m (was: 1.5h)
> HMS server should throw InvalidObjectException in get_partitions_by_names()
> when the table is missing/dropped
> -------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-27319
> URL: https://issues.apache.org/jira/browse/HIVE-27319
> Project: Hive
> Issue Type: Bug
> Components: Hive, Standalone Metastore
> Reporter: Sai Hemanth Gantasala
> Assignee: Sai Hemanth Gantasala
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> When the table object is dropped by a concurrent thread, the
> get_partitions_by_names_req() API is currently throwing a
> TApplicationException to the client. Instead, the HMS server should propagate
> the InvalidObjectException thrown by getTable() to the HMS client. By doing
> this, other services using HMS client will understand the exception better.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
