[
https://issues.apache.org/jira/browse/HIVE-27578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Soumyakanti Das updated HIVE-27578:
-----------------------------------
Description:
Currently {{genJoinRelNode}} method relies on {{genAllExprNodeDesc}} for adding
backticks to the ON clause conditions, but we can use {{genAllRexNode}} method
instead, and not rely on ExprNodes.
There was a previous effort to try to get RexNodes directly from AST, and this
method call was probably overlooked. We can see that changes were made around
this method call to use RexNodes instead of ExprNodes,
[here|https://github.com/apache/hive/pull/970/files#diff-fc58b141b1cc612eb221bb781c83e1a5c98e054790b2803be60b4842d0e9a5d9R2753].
Relevant previous Jiras:
# HIVE-23100
# HIVE-22746
With this change, we can avoid going through the method {{genAllExprNodeDesc}}
and avoid mixing RexNodes and ExprNodes.
was:Currently {{genJoinRelNode}} method relies on {{genAllExprNodeDesc}} for
adding backticks to the ON clause, but we can use {{genAllRexNode}} method
instead, which is better because we already use RexNodes in the method and this
change will make it depend on only RexNodes
> Refactor genJoinRelNode to use genAllRexNode instead of genAllExprNodeDesc
> --------------------------------------------------------------------------
>
> Key: HIVE-27578
> URL: https://issues.apache.org/jira/browse/HIVE-27578
> Project: Hive
> Issue Type: Improvement
> Reporter: Soumyakanti Das
> Assignee: Soumyakanti Das
> Priority: Major
> Labels: pull-request-available
>
> Currently {{genJoinRelNode}} method relies on {{genAllExprNodeDesc}} for
> adding backticks to the ON clause conditions, but we can use
> {{genAllRexNode}} method instead, and not rely on ExprNodes.
> There was a previous effort to try to get RexNodes directly from AST, and
> this method call was probably overlooked. We can see that changes were made
> around this method call to use RexNodes instead of ExprNodes,
> [here|https://github.com/apache/hive/pull/970/files#diff-fc58b141b1cc612eb221bb781c83e1a5c98e054790b2803be60b4842d0e9a5d9R2753].
>
> Relevant previous Jiras:
> # HIVE-23100
> # HIVE-22746
> With this change, we can avoid going through the method
> {{genAllExprNodeDesc}} and avoid mixing RexNodes and ExprNodes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
