[
https://issues.apache.org/jira/browse/HIVE-28028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813963#comment-17813963
]
Raghav Aggarwal commented on HIVE-28028:
----------------------------------------
[~abstractdog], Currently Hive uses tez 0.10.2 and in ProtoMessageWritable.java
of tez 0.10.2
[https://github.com/apache/tez/blob/72977b8720b2337ab0a0a3bf3b12e1c57900fa69/tez-plugins/tez-protobuf-history-plugin/src/main/java/org/apache/tez/dag/history/logging/proto/ProtoMessageWritable.java#L99]
The value of extensionRegistry is null, but in HIVE-24483 the value is set to a
new instance. As tez 0.10.2 uses protobuf version 2.5.0, and hive has protobuf
3.21.7, the difference in generated code for
[HiveHookEvents.java|https://github.com/apache/hive/blob/master/ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/hooks/proto/HiveHookEvents.java]
result in test failure in
[TestHiveProtoLoggingHook.java|https://github.com/apache/hive/blob/master/ql/src/test/org/apache/hadoop/hive/ql/hooks/TestHiveProtoLoggingHook.java]
(tested in local).
If I push the patch now, there will be UT failures. Let me know what should be
the best couse of action.
> Remove duplicated proto reader/writer classes introduced in HIVE-19288
> ----------------------------------------------------------------------
>
> Key: HIVE-28028
> URL: https://issues.apache.org/jira/browse/HIVE-28028
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: Raghav Aggarwal
> Priority: Major
>
> introduced in commit:
> https://github.com/apache/hive/commit/8349dbde55f479167e43cfd1f089e131d4271e5b
> as discussed in a related PR: https://github.com/apache/hive/pull/5033, we
> should
> 1. check if anything has been contributed to those compared to what we
> currently have on tez/master
> 2. remove those
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
