[
https://issues.apache.org/jira/browse/HIVE-28072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor updated HIVE-28072:
--------------------------------
Description:
As discussed on https://lists.apache.org/thread/6rwrvsy1vn94hhs62x5tl125g3ft22kq
original mail:
{code}
What do you think about forcing coding style in Hive precommit?
I remember, back in the old days, precommit printed some warnings in case
some coding style (formatting, indentation, naming convention, etc.)
problems were found in the patch, now it's simply not used, I guess since
we're using GitHub PRs.
For example: I remember I simply approved a PR a few months ago which LGTM,
and later just realized it's full of 4-spaces indentation, which is wrong
if we assume that code should be formatted according to the style
definition here:
https://github.com/apache/hive/blob/master/dev-support/eclipse-styles.xml
{code}
> Check style in Hive Github PRs
> ------------------------------
>
> Key: HIVE-28072
> URL: https://issues.apache.org/jira/browse/HIVE-28072
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Priority: Major
>
> As discussed on
> https://lists.apache.org/thread/6rwrvsy1vn94hhs62x5tl125g3ft22kq
> original mail:
> {code}
> What do you think about forcing coding style in Hive precommit?
> I remember, back in the old days, precommit printed some warnings in case
> some coding style (formatting, indentation, naming convention, etc.)
> problems were found in the patch, now it's simply not used, I guess since
> we're using GitHub PRs.
> For example: I remember I simply approved a PR a few months ago which LGTM,
> and later just realized it's full of 4-spaces indentation, which is wrong
> if we assume that code should be formatted according to the style
> definition here:
> https://github.com/apache/hive/blob/master/dev-support/eclipse-styles.xml
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
