[ 
https://issues.apache.org/jira/browse/HIVE-8396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006564#comment-15006564
 ] 

Elliot West commented on HIVE-8396:
-----------------------------------

I note that in {{org.apache.hadoop.hive.cli.CliDriver}} the following code 
strips full line comments from the input script:
{code}
  public int processReader(BufferedReader r) throws IOException {
    String line;
    StringBuilder qsb = new StringBuilder();
    while ((line = r.readLine()) != null) {
      // Skipping through comments
      if (! line.startsWith("--")) {
        qsb.append(line + "\n");
      }
    }
    return (processLine(qsb.toString()));
  }
{code}
Can we not also do this in the shell input processor? Also, what does 
{{beeline}} do?

> Hive CliDriver command splitting can be broken when comments are present
> ------------------------------------------------------------------------
>
>                 Key: HIVE-8396
>                 URL: https://issues.apache.org/jira/browse/HIVE-8396
>             Project: Hive
>          Issue Type: Bug
>          Components: Parser, Query Processor
>    Affects Versions: 0.14.0
>            Reporter: Sergey Shelukhin
>
> {noformat}
> -- SORT_QUERY_RESULTS
> set hive.cbo.enable=true;
> ... commands ...
> {noformat}
> causes
> {noformat}
> 2014-10-07 18:55:57,193 ERROR ql.Driver (SessionState.java:printError(825)) - 
> FAILED: ParseException line 2:4 missing KW_ROLE at 'hive' near 'hive'
> {noformat}
> If the comment is moved after the command it works.
> I noticed this earlier when I comment out parts of some random q file for 
> debugging purposes, and it starts failing. This is annoying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to