[
https://issues.apache.org/jira/browse/HIVE-28135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829471#comment-17829471
]
Stamatis Zampetakis commented on HIVE-28135:
--------------------------------------------
The hander logic was introduced by HIVE-2154 so I guess we are talking about
reverting that change. I am curious if [~ningzhangnj] [~he yongqiang] have any
insights about why this was added in the first place since the motivation is
not obvious in the Jira, code, or commit message.
> Remove HiveIOExceptionHandlerUtil
> ---------------------------------
>
> Key: HIVE-28135
> URL: https://issues.apache.org/jira/browse/HIVE-28135
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Priority: Major
>
> 1. old history, not really touched:
> https://github.com/apache/hive/commits/master/shims/common/src/main/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java
> 2. cannot see a clear usecase
> {code}
> RecordReader innerReader = null;
> try {
> innerReader = inputFormat.getRecordReader(targetSplit, job,
> reporter);
> } catch (Exception e) {
> innerReader = HiveIOExceptionHandlerUtil
> .handleRecordReaderCreationException(e, job);
> }
> {code}
> define an exception handler to magically create a reader? this looks so hacky
> 3. cannot find and useful usage of "hive.io.exception.handlers" by googling
> 4. swallows exception as described in HIVE-28133
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
