[ 
https://issues.apache.org/jira/browse/HIVE-28036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835578#comment-17835578
 ] 

László Bodor commented on HIVE-28036:
-------------------------------------

merged to master, thanks [~dkuzmenko] and [~InvisibleProgrammer] for the 
reviews!

> Move checkLock method to TestTxnDbUtil
> --------------------------------------
>
>                 Key: HIVE-28036
>                 URL: https://issues.apache.org/jira/browse/HIVE-28036
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.1.0
>
>
> Referring to a method from a different unit test class is crazy, we need to 
> move it.
> When calling a method like TestDbTxnManager2.checkLock, the @ClassRule of 
> TestDbTxnManager2 is called which can potentially screw up things, so this is 
> kind of blocking some stuff in HIVE-27972 as well. Unit test classes should 
> only depend on each other in the same inheritance chain.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to