[ 
https://issues.apache.org/jira/browse/HIVE-11358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009330#comment-15009330
 ] 

Siddharth Seth commented on HIVE-11358:
---------------------------------------

bq. One question is, do we need a separate daemon config, or should we just use 
hive-site.xml for everything?
Separate is better IMO, something other than hive-site.xml is less ambiguous. 
Also leaving this as hive-site likely means a large (100+ k-v) config file for 
LLAP - of which only about 10 are required.

Given LLAP is a new component - we could get started with separating client and 
server configs - along with the files.
e.g.
llap.daemon.rpc.num.handlers (and a lot of other configs) <- useless in client 
configs (hive-site on the client / hive-server)
llap.daemon.num.executors (and a few other configs) <- #threads for a daemon. 
Used by the client to determine available slots when not using slider. The 
client config could be renamed.

IAC, that's beyond the scope of what this jira is doing. Using annotations to 
separate config parameters to generate the public list of configurable fields 
would work.

I'll create a separate jira to separate llap server-side and client-side 
configs.

+1 for the patch.




> LLAP: move LlapConfiguration into HiveConf and document the settings
> --------------------------------------------------------------------
>
>                 Key: HIVE-11358
>                 URL: https://issues.apache.org/jira/browse/HIVE-11358
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-11358.01.patch, HIVE-11358.patch
>
>
> Hive uses HiveConf for configuration. LlapConfiguration should be replaced 
> with parameters in HiveConf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to