[
https://issues.apache.org/jira/browse/HIVE-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015083#comment-15015083
]
Dapeng Sun commented on HIVE-12367:
-----------------------------------
Thank [~sershe] and [~alangates].
{quote}Do files need the out file update?{quote}
Thank you for pointing out it. I will update the out files.
{quote}
A comment on why you are selecting DDL_NO_LOCK in the lock function would be
helpful, since it's confusing.
{quote}
How about using {{DDL_SHARED}} or {{DDL_EXCLUSIVE}} (depends on lock mode) at
Lock and using {{DDL_NO_LOCK}} at Unlock
{quote}analyzeLockTable and analyzeUnlockTable suffer from the same problem. I
don't know if you want to fix those as well.{quote}
Thank you for pointing out it. I'm willing to, I will update it at this ticket
or file another jira to fix it, do you think it is okay?
> Lock/unlock database should add current database to inputs and outputs of
> authz hook
> ------------------------------------------------------------------------------------
>
> Key: HIVE-12367
> URL: https://issues.apache.org/jira/browse/HIVE-12367
> Project: Hive
> Issue Type: Bug
> Components: Authorization
> Affects Versions: 1.2.1
> Reporter: Dapeng Sun
> Assignee: Dapeng Sun
> Attachments: HIVE-12367.001.patch, HIVE-12367.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
