[ 
https://issues.apache.org/jira/browse/HIVE-29224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HIVE-29224:
----------------------------------
    Labels: pull-request-available  (was: )

> Move TPC-DS CTE suggestion tests in new test suite
> --------------------------------------------------
>
>                 Key: HIVE-29224
>                 URL: https://issues.apache.org/jira/browse/HIVE-29224
>             Project: Hive
>          Issue Type: Task
>          Components: Tests
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>              Labels: pull-request-available
>
> HIVE-28259 introduced a new experimental feature for finding and 
> materializing common table expressions (CTEs) using CBO. The effect of the 
> suggester on TPC-DS queries was tested using the 
> TestTezTPCDS30TBPerfCliDriver.
> As it is right now we cannot easily fine-tune other CTE related 
> configurations (e.g., hive.optimize.cte.materialize.threshold) without 
> affecting existing query plans and doing so may decrease test coverage for 
> certain parts of the engine.
> I propose to move the suggester based ("hive.optimize.cte.suggester.class") 
> tests under a new test suite (new TestTPCDSCteCliDriver) relying on the 
> TPC-DS 30TB stats focusing on CTE materialization/suggestion features.
> *Pros* 
>  * Increase in test coverage
>  * No coupling of experimental features with main plan regression suite
> *Cons*
>  * Increase in test runtime
>  * Redundancy in golden files (*.q.out)
> Once the CTE feature(s) are stabilized and become part of the default 
> configuration it will no longer be necessary to maintain a separate suite.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to