[
https://issues.apache.org/jira/browse/HIVE-29442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shohei Okumiya resolved HIVE-29442.
-----------------------------------
Fix Version/s: 4.3.0
Resolution: Fixed
Merged. [~thomas.rebele] Thanks for giving the patch!
https://github.com/apache/hive/pull/6300
> Avoid redundancy in FilterStatsRule#evaluateComparator
> ------------------------------------------------------
>
> Key: HIVE-29442
> URL: https://issues.apache.org/jira/browse/HIVE-29442
> Project: Hive
> Issue Type: Task
> Reporter: Thomas Rebele
> Assignee: Thomas Rebele
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.3.0
>
>
> The bottom part of
> [FilterStatsRule#evaluateComparator|https://github.com/apache/hive/blob/7b5433415e42ec92d29636109ea7f522c9354cf4/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java#L1071-L1267]
> repeats a very similar code block 6 times. Implementing HIVE-29364 will
> likely make the repeated code block even bigger. I suggest to combine those
> code blocks into a single one, while still keeping the same behavior.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
