[
https://issues.apache.org/jira/browse/HIVE-29464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor updated HIVE-29464:
--------------------------------
Description:
1. getter for a mutable collection is extensively used:
```
public Map<String, PartitionDesc> getAliasToPartnInfo() {
return aliasToPartnInfo;
}
```
so we don't have an idea when partitions are actually added to this collection
2. setter is not used at all
```
public void setAliasToPartnInfo(
LinkedHashMap<String, PartitionDesc> aliasToPartnInfo) {
this.aliasToPartnInfo = aliasToPartnInfo;
}
```
3. some callers of this method only relies to TableDesc objects, which is
usually one and only TableDesc for thousands of PartitionDesc objects, shall we
consider introducing another method for retrieving TableDesc
4. TODO: check if it is possible to have multiple TableDesc for the same
MapWork, and design the TableDesc getter accordingly
> Rethink MapWork.aliasToPartnInfo
> --------------------------------
>
> Key: HIVE-29464
> URL: https://issues.apache.org/jira/browse/HIVE-29464
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Priority: Major
>
> 1. getter for a mutable collection is extensively used:
> ```
> public Map<String, PartitionDesc> getAliasToPartnInfo() {
> return aliasToPartnInfo;
> }
> ```
> so we don't have an idea when partitions are actually added to this collection
> 2. setter is not used at all
> ```
> public void setAliasToPartnInfo(
> LinkedHashMap<String, PartitionDesc> aliasToPartnInfo) {
> this.aliasToPartnInfo = aliasToPartnInfo;
> }
> ```
> 3. some callers of this method only relies to TableDesc objects, which is
> usually one and only TableDesc for thousands of PartitionDesc objects, shall
> we consider introducing another method for retrieving TableDesc
> 4. TODO: check if it is possible to have multiple TableDesc for the same
> MapWork, and design the TableDesc getter accordingly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
