[
https://issues.apache.org/jira/browse/HIVE-29461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18059933#comment-18059933
]
Denys Kuzmenko edited comment on HIVE-29461 at 2/20/26 4:15 PM:
----------------------------------------------------------------
regarding
{code}
propertiesMap.put("externalwarehouse", extWarehouse); in
IcebergSummaryHandler.java
vs
properties.put("external-warehouse", configExtWarehouse); in
HMSCatalogFactory.java
{code}
i think it's a bug :) we should extract keys to the `IcebergCatalogProperties`
> `external-warehouse` is not part of CatalogProperties and is specific to
> hive4. How will other projects even know that something like this exists?
you are absolutely right, they won't :)
was (Author: dkuzmenko):
regarding
{code}
propertiesMap.put("externalwarehouse", extWarehouse); in
IcebergSummaryHandler.java
vs
properties.put("external-warehouse", configExtWarehouse); in
HMSCatalogFactory.java
{code}
i think it's a bug :) we should extract keys to the `IcebergCatalogProperties`
constants
> `external-warehouse` is not part of CatalogProperties and is specific to
> hive4. How will other projects even know that something like this exists?
you are absolutely right, they won't :)
> Iceberg: HIVE_METASTORE_WAREHOUSE_EXTERNAL is ignored when initializing
> HiveCatalog
> -----------------------------------------------------------------------------------
>
> Key: HIVE-29461
> URL: https://issues.apache.org/jira/browse/HIVE-29461
> Project: Hive
> Issue Type: Bug
> Components: Iceberg integration
> Affects Versions: 4.2.0
> Reporter: Denys Kuzmenko
> Priority: Major
> Labels: hive-4.3.0-must
>
> stacktrace
> {code}
> (executor-thread-1) Unhandled exception returning INTERNAL_SERVER_ERROR :
> java.lang.NullPointerException: Warehouse location is not set:
> hive.metastore.warehouse.external.dir=null
> {code}
> invocation
> {code}
> private String getExternalWarehouseLocation() {
> String warehouseLocation =
> conf.get(HiveConf.ConfVars.HIVE_METASTORE_WAREHOUSE_EXTERNAL.varname);
> Preconditions.checkNotNull(warehouseLocation,
> "Warehouse location is not set:
> hive.metastore.warehouse.external.dir=null");
> return warehouseLocation;
> }
> {code}
> HIVE_METASTORE_WAREHOUSE_EXTERNAL is missing in
> {code}
> public void initialize(String inputName, Map<String, String> properties) {
> this.catalogProperties = ImmutableMap.copyOf(properties);
> ....
> if (properties.containsKey(CatalogProperties.WAREHOUSE_LOCATION)) {
> this.conf.set(HiveConf.ConfVars.METASTORE_WAREHOUSE.varname,
>
> LocationUtil.stripTrailingSlash(properties.get(CatalogProperties.WAREHOUSE_LOCATION)));
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
