[ 
https://issues.apache.org/jira/browse/HIVE-29470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18061565#comment-18061565
 ] 

Kokila N commented on HIVE-29470:
---------------------------------

Hi [~abstractdog] 
I have created a PR with a UT 
{*}testCommonLocalResourcesPopulatedOnSessionOpen{*}() to verify that 
commonLocalResources includes:
the hive-exec app jar and all localized resources(currently one from test 
itself {*}test-jar{*}) when opening a Tez session.

Executed the test after commenting the lines same as your draft PR and verified 
it fails. 

Could you please review it ? 

> Double-check if precommit covers real Tez on Yarn jar localization
> ------------------------------------------------------------------
>
>                 Key: HIVE-29470
>                 URL: https://issues.apache.org/jira/browse/HIVE-29470
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: Kokila N
>            Priority: Major
>              Labels: pull-request-available
>
> Recently, in a downstream precommit I made a fatal failure in TezSessionState 
> related to hive-exec jar localization, and the normal precommit tests didn't 
> cover it. Need to double-check that's the case upstream too, so I'll create a 
> dummy PR that does a similar mistake.
> See this example commit that disables jar localization: 
> https://github.com/abstractdog/hive/commit/06ce23fb04bb2e862d0cf511f5ac214ce1e6bee9



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to