[ 
https://issues.apache.org/jira/browse/HIVE-12307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027381#comment-15027381
 ] 

Alan Gates commented on HIVE-12307:
-----------------------------------

+1

bq. It's worthwhile to do a thread safety review but was not my goal here.
Agreed, I'm not trying to add a thread safety review to this patch.

I've created HIVE-12521 to start tracking javadoc issues in Hive streaming.  
I've put in there that we should document the assumptions about thread safety 
and the meaning of SerializationError.  If there are other issues you are aware 
of in here that need documenting feel free to add to that JIRA.  I've assigned 
it to myself so I don't forget about it but feel free to take it on if you want.





> Streaming API TransactionBatch.close() must abort any remaining transactions 
> in the batch
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-12307
>                 URL: https://issues.apache.org/jira/browse/HIVE-12307
>             Project: Hive
>          Issue Type: Bug
>          Components: HCatalog, Transactions
>    Affects Versions: 0.14.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>         Attachments: HIVE-12307.2.patch, HIVE-12307.patch
>
>
> When the client of TransactionBatch API encounters an error it must close() 
> the batch and start a new one.  This prevents attempts to continue writing to 
> a file that may damaged in some way.
> The close() should ensure to abort the any txns that still remain in the 
> batch and close (best effort) all the files it's writing to.  The batch 
> should also put itself into a mode where any future ops on this batch fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to