[
https://issues.apache.org/jira/browse/HIVE-28135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18080270#comment-18080270
]
Stamatis Zampetakis commented on HIVE-28135:
--------------------------------------------
The claim in the description that HiveIOExceptionHandlerUtil is swallowing
exceptions happens only in rare cases. If a user sets the
hive.io.exception.handlers property and uses a custom handler the exception may
disappear however, in practice I never saw this happening. The default value
for the property is an empty string so in most (if not all) production
use-cases the exception is not swallowed by the handler but propagates upwards
wrapped as an IOException.
The above comment is just an additional clarification to avoid potential
misinterpretation by users & devs.
> Remove HiveIOExceptionHandlerUtil
> ---------------------------------
>
> Key: HIVE-28135
> URL: https://issues.apache.org/jira/browse/HIVE-28135
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.2.0
>
>
> 1. old history, not really touched:
> https://github.com/apache/hive/commits/master/shims/common/src/main/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java
> 2. cannot see a clear usecase
> {code}
> RecordReader innerReader = null;
> try {
> innerReader = inputFormat.getRecordReader(targetSplit, job,
> reporter);
> } catch (Exception e) {
> innerReader = HiveIOExceptionHandlerUtil
> .handleRecordReaderCreationException(e, job);
> }
> {code}
> define an exception handler to magically create a reader? this looks so hacky
> 3. cannot find and useful usage of "hive.io.exception.handlers" by googling
> 4. swallows exception as described in HIVE-28133
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
