[ 
https://issues.apache.org/jira/browse/HIVE-29747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stamatis Zampetakis updated HIVE-29747:
---------------------------------------
    Description: 
Various changes (e.g., HIVE-29184, HIVE-29699) require changes to .thrift 
files. Quite often contributors fail to execute the automatic Thrift code 
generator logic (via thriftif profile) leading to partial or broken Thrift 
implementations.

The goal is to add a CI check (potentially in Jenkinsfile) so that every time 
that .thrift files are modified by a PR the check runs and ensures that the 
generated Thrift code is correct and complete. In other words, the content 
under src/gen/thrift directory matches the content of the pull request.

  was:
Various changes (e.g., HIVE-29184, HIVE-29746) require changes to .thrift 
files. Quite often contributors fail to execute the automatic Thrift code 
generator logic (via thriftif profile) leading to partial or broken Thrift 
implementations.

The goal is to add a CI check (potentially in Jenkinsfile) so that every time 
that .thrift files are modified by a PR the check runs and ensures that the 
generated Thrift code is correct and complete. In other words, the content 
under src/gen/thrift directory matches the content of the pull request.


> Add CI check to ensure Thrift code generation run
> -------------------------------------------------
>
>                 Key: HIVE-29747
>                 URL: https://issues.apache.org/jira/browse/HIVE-29747
>             Project: Hive
>          Issue Type: Task
>          Components: Test
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>
> Various changes (e.g., HIVE-29184, HIVE-29699) require changes to .thrift 
> files. Quite often contributors fail to execute the automatic Thrift code 
> generator logic (via thriftif profile) leading to partial or broken Thrift 
> implementations.
> The goal is to add a CI check (potentially in Jenkinsfile) so that every time 
> that .thrift files are modified by a PR the check runs and ensures that the 
> generated Thrift code is correct and complete. In other words, the content 
> under src/gen/thrift directory matches the content of the pull request.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to