[
https://issues.apache.org/jira/browse/HIVE-29765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18102111#comment-18102111
]
Stamatis Zampetakis commented on HIVE-29765:
--------------------------------------------
Indeed if we override a method it should work as expected so the question
becomes should we override the method? If the override was not there in the
first place then the unparse method would be correct although the output could
be somewhat surprising to those looking into the Optimized SQL entry.
Anyways, at this point the fix in the PR makes sense so we can merge it. The
main point that I wanted to make is if its worth investing time (contributor +
reviewer), maintenance effort (extra code + overrides), and compute resources
(CI runs) on features (Optimized SQL) with low value.
> HiveBetween#unparse ignores negated flag
> ----------------------------------------
>
> Key: HIVE-29765
> URL: https://issues.apache.org/jira/browse/HIVE-29765
> Project: Hive
> Issue Type: Bug
> Reporter: Ruben Q L
> Assignee: Ruben Q L
> Priority: Major
> Labels: pull-request-available
>
> HiveBetween first operand is a boolean "negated" flag. When it is disabled
> (default) the operator represents a standard BETWEEN. When it is enabled, the
> operator represents a NOT BETWEEN. However, in the HiveBetween#unparse method
> the flag is not considered, so in all cases it is unparsed as a "BETWEEN"
> (even when the flag is activated).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
