Udit Kumar created HIVE-30063:
---------------------------------
Summary: Generating the gRPC proto from thrift instead of manual
creation
Key: HIVE-30063
URL: https://issues.apache.org/jira/browse/HIVE-30063
Project: Hive
Issue Type: Improvement
Components: Standalone Metastore
Reporter: Udit Kumar
For the standalone-metastore the proto file
{code:java}
standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/hive_metastore.proto
{code}
this seems to be manually created instead of generating from some Thrift to
proto generator due to which the som of the new fields in the thrift are not
present in proto file
one example of this is the Catalog
where the thrift is
{code:java}
struct Catalog {
1: string name, // Name of the catalog
2: optional string description, // description of the catalog
3: string locationUri, // default storage location. When
databases are created in
// this catalog, if they do not specify a
location, they will
// be placed in this location.
4: optional i32 createTime, // creation time of catalog in seconds
since epoch
5: optional map<string, string> parameters
} {code}
but the proto file only
{code:java}
message Catalog {
string name = 1;
string description = 2;
string location_uri = 3;
int32 create_time = 4;
} {code}
the field *parameters* is missing, and there are multiple such examples
which have make the proto file stale.
So instead of manually updating proto file, it will be better to generate the
changes in the proto file at build which check to see the the proto changes are
breaking changes or not also.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
