[
https://issues.apache.org/jira/browse/HIVE-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058348#comment-15058348
]
Ted Yu commented on HIVE-7305:
------------------------------
lgtm
nit:
indentation is off
please add space between if and '('
> Return value from in.read() is ignored in SerializationUtils#readLongLE()
> -------------------------------------------------------------------------
>
> Key: HIVE-7305
> URL: https://issues.apache.org/jira/browse/HIVE-7305
> Project: Hive
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: skrho
> Priority: Minor
> Attachments: HIVE-7305_001.patch
>
>
> {code}
> long readLongLE(InputStream in) throws IOException {
> in.read(readBuffer, 0, 8);
> return (((readBuffer[0] & 0xff) << 0)
> + ((readBuffer[1] & 0xff) << 8)
> {code}
> Return value from read() may indicate fewer than 8 bytes read.
> The return value should be checked.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
