[
https://issues.apache.org/jira/browse/HIVE-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060807#comment-15060807
]
Vikram Dixit K commented on HIVE-12667:
---------------------------------------
I guess the string-string could be special-cased to avoid some unnecessary
calls. Otherwise the code looks good to me. +1
> Proper fix for HIVE-12473
> -------------------------
>
> Key: HIVE-12667
> URL: https://issues.apache.org/jira/browse/HIVE-12667
> Project: Hive
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: HIVE-12667.1.patch
>
>
> HIVE-12473 has added an incorrect comment and also lacks a test case.
> Benefits of this fix:
> * Does not say: "Probably doesn't work"
> * Does not use grammar like "subquery columns and such"
> * Adds test cases, that let you verify the fix
> * Doesn't rely on certain structure of key expr, just takes the type at
> compile time
> * Doesn't require an additional walk of each key expression
> * Shows the type used in explain
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)