[ 
https://issues.apache.org/jira/browse/HIVE-12418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086149#comment-15086149
 ] 

Naveen Gangam commented on HIVE-12418:
--------------------------------------


We had removed this form the original fix and committed without overriding 
finalize(). On re-testing the fix in a customer environment, customer reported 
that the fix with finalize() worked whereas the fix without the finalize() did 
not work. As this was the only difference, we had to re-insert the finalize() 
method.

With the new fix, the customer still reports that the original test fix works 
whereas the official fix does not resolve the issue (at this point they should 
be the same). I suspect this is an environmental issue now as opposed to having 
finalize().
I have used classes with finalize() in the past enough in WebLogic's JTA 
implementation (back in JDK1.3/1.4 era) and have not heard of any issues. But I 
am good with removing the finalize() if it is concerning.

> HiveHBaseTableInputFormat.getRecordReader() causes Zookeeper connection leak.
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-12418
>                 URL: https://issues.apache.org/jira/browse/HIVE-12418
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>    Affects Versions: 1.1.0
>            Reporter: Naveen Gangam
>            Assignee: Naveen Gangam
>             Fix For: 2.0.0
>
>         Attachments: HIVE-12418.patch
>
>
>   @Override
>   public RecordReader<ImmutableBytesWritable, ResultWritable> getRecordReader(
> ...
> ...
>  setHTable(HiveHBaseInputFormatUtil.getTable(jobConf));
> ...
> The HiveHBaseInputFormatUtil.getTable() creates new ZooKeeper 
> connections(when HTable instance is created) which are never closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to