[
https://issues.apache.org/jira/browse/HIVE-11716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127452#comment-15127452
]
Eugene Koifman commented on HIVE-11716:
---------------------------------------
ErrorMsg.TXNMGR_NOT_ACID - this should be a parametrized message. At minimum,
it should include db_name.table_name. Perhaps it should also include first 10
or 20 chars of the command itself to make easier to read the logs down the road.
I don't think SessionState.initTxnMgr() works long term. What if we add
BetterTxnManger later? I would, in addition to txnMgr also add txnMgrName to
remember the last property name or perhaps better add
HiveTxnManager.getTxnManagerName() so that you can query currently installed
manager for its name.
Nit: In TestDbTxnManager2.testDummyTxnManagerOnAcidTable(). Instead of 10265,
etc could you use ErrorMsg.TXNMGR_NOT_ACID, etc
> Reading ACID table from non-acid session should raise an error
> --------------------------------------------------------------
>
> Key: HIVE-11716
> URL: https://issues.apache.org/jira/browse/HIVE-11716
> Project: Hive
> Issue Type: Bug
> Components: Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Wei Zheng
> Priority: Critical
> Attachments: HIVE-11716.1.patch, HIVE-11716.2.patch,
> HIVE-11716.3.patch, HIVE-11716.4.patch, HIVE-11716.5.patch
>
>
> if someone performs a delete using DbTxnManager and than starts a new session
> with DummyTxnManager, then previously successfully deleted data will show up.
> Once the logic to identify all acid tables being read is there, make sure that
> Driver.recordValidTxns() called iff there ACID tables in the query.
> We should also not allow writing to ACID table from non-acid session
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
