[
https://issues.apache.org/jira/browse/HIVE-7862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130931#comment-15130931
]
Hive QA commented on HIVE-7862:
-------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12785775/HIVE-7862.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10050 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hive.jdbc.TestSSL.testSSLVersion
org.apache.hive.service.cli.TestEmbeddedThriftBinaryCLIService.testExecuteStatementAsync
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6853/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6853/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6853/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12785775 - PreCommit-HIVE-TRUNK-Build
> close of InputStream in Utils#copyToZipStream() should be placed in finally
> block
> ---------------------------------------------------------------------------------
>
> Key: HIVE-7862
> URL: https://issues.apache.org/jira/browse/HIVE-7862
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.13.0
> Reporter: Ted Yu
> Assignee: skrho
> Priority: Minor
> Labels: patch
> Attachments: HIVE-7862.1.patch, HIVE-7862.1.patch, HIVE-7862_001.txt
>
>
> In accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/Utils.java ,
> line 278 :
> {code}
> private static void copyToZipStream(InputStream is, ZipEntry entry,
> ZipOutputStream zos)
> throws IOException {
> zos.putNextEntry(entry);
> byte[] arr = new byte[4096];
> int read = is.read(arr);
> while (read > -1) {
> zos.write(arr, 0, read);
> read = is.read(arr);
> }
> is.close();
> {code}
> If read() throws IOException, is would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
