[
https://issues.apache.org/jira/browse/HIVE-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131178#comment-15131178
]
Szehon Ho commented on HIVE-12987:
----------------------------------
Thanks for the patch.. I had some comments.
1. The overriding of the metrics-prefix strings seems confusing, can't we just
add some new constants/prefixes in MetricsConstants and have Sqloperation
increment/decrement those explicitly as part of overriding the setMetrics
method? And moreover with this code, I think we may be not getting some old
metrics in case of SQLOperation, wouldn't it stop increment/decrement the total
count?
2. The increment/decrementUserQuery methods also seem a bit complicated. Why
do we need extra map in SQLOperation? I think the counter-map already in
CodahaleMetrics should take care of all the stuff the new map does?
Those were my two main concerns, otherwise change makes sense. Also i am OOO
at the moment, you can also ping someone else if I'm a bit slow to respond.
Thanks
> Add metrics for HS2 active users and SQL operations
> ---------------------------------------------------
>
> Key: HIVE-12987
> URL: https://issues.apache.org/jira/browse/HIVE-12987
> Project: Hive
> Issue Type: Task
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Attachments: HIVE-12987.1.patch, HIVE-12987.2.patch
>
>
> HIVE-12271 added metrics for all HS2 operations. Sometimes, users are also
> interested in metrics just for SQL operations.
> It is useful to track active user count as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
