[ 
https://issues.apache.org/jira/browse/HIVE-12839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135471#comment-15135471
 ] 

Pengcheng Xiong commented on HIVE-12839:
----------------------------------------

[~ashutoshc], sure. The major change is in the HiveRelFieldTrimmer. I added a 
new function
{code}
public TrimResult trimFields(
183           HiveSortLimit sort,
184           ImmutableBitSet fieldsUsed,
185           Set<RelDataTypeField> extraFields) {
{code}
which was copied and pasted from Calcite. It calls a function 
{code}
sortLimit(cluster, relBuilder, offset, fetch, fields);
{code}
And inside sortLimit, I removed the line 
{code}
return empty LogicalValues when offset == 0 && fetch == 0.
{code}
Thus, it will fall back to the processing logic in Calcite 1.5. I also added 
some "TODO" in the comments. Thanks.

> Upgrade Hive to Calcite 1.6
> ---------------------------
>
>                 Key: HIVE-12839
>                 URL: https://issues.apache.org/jira/browse/HIVE-12839
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Pengcheng Xiong
>            Assignee: Pengcheng Xiong
>         Attachments: HIVE-12839.01.patch, HIVE-12839.02.patch, 
> HIVE-12839.03.patch, HIVE-12839.04.patch
>
>
> CLEAR LIBRARY CACHE
> Upgrade Hive to Calcite 1.6.0-incubating.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to