[ 
https://issues.apache.org/jira/browse/HIVE-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149437#comment-15149437
 ] 

Alan Gates commented on HIVE-12064:
-----------------------------------

In general looks good.  A couple of minor issues:

The error message ""The table must be bucketed and stored as ORC in order to be 
transactional" should be something like: "The table must be bucketed and stored 
using an ACID compliant format (such as ORC)".  This way if a user implements 
their own format or other formats implement ACID the error message is still 
valid.

When checking validity of a createTableStatement with false, you let the false 
through to avoid backwards compatibility issues.  I agree this is the right 
choice, but there should be an LOG.info() there to tell users we're ignoring 
and dropping the value.



> prevent transactional=false
> ---------------------------
>
>                 Key: HIVE-12064
>                 URL: https://issues.apache.org/jira/browse/HIVE-12064
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Wei Zheng
>            Priority: Critical
>         Attachments: HIVE-12064.2.patch, HIVE-12064.3.patch, 
> HIVE-12064.4.patch, HIVE-12064.patch
>
>
> currently a tblproperty transactional=true must be set to make a table behave 
> in ACID compliant way.
> This is misleading in that it seems like changing it to transactional=false 
> makes the table non-acid but on disk layout of acid table is different than 
> plain tables.  So changing this  property may cause wrong data to be returned.
> Should prevent transactional=false.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to