[
https://issues.apache.org/jira/browse/HIVE-13170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169303#comment-15169303
]
Josh Elser commented on HIVE-13170:
-----------------------------------
Took a quick look and left you some comments on the pull-request. Thanks again
for submitting the changes.
> HiveAccumuloTableOutputFormat should implement HiveOutputFormat to ensure
> compatibility
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-13170
> URL: https://issues.apache.org/jira/browse/HIVE-13170
> Project: Hive
> Issue Type: Bug
> Components: Accumulo Storage Handler
> Affects Versions: 1.2.1, 2.0.0
> Reporter: Teng Qiu
> Assignee: Teng Qiu
>
> this issue was caused by same reason described in
> https://issues.apache.org/jira/browse/HIVE-11166
> both HiveAccumuloTableOutputFormat and HiveHBaseTableOutputFormat does not
> implemented HiveOutputFormat, it may break the compatibility in some other
> APIs that are using hive, such as spark's API.
> spark expects the OutputFormat called by hive storage handler is some kind of
> HiveOutputFormat. which is totally reasonable.
> and since they are OutputFormat for hive storage handler, they should not
> only extend the 3rd party OutputFormat (AccumuloOutputFormat or
> hbase.TableOutputFormat), but also implement HiveOutputFormat interface.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)