[
https://issues.apache.org/jira/browse/HIVE-13342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209416#comment-15209416
]
Siddharth Seth commented on HIVE-13342:
---------------------------------------
Couple of possible enhancements.
LOG.info("some operators cannot be run in llap"); - not very useful. This
should include additional context. Is that coming from other log lines ?
{code}
throw new SemanticException("Llap mode is set to all but cannot run work in
llap mode. "
+ "Set hive.llap.execution.mode = auto or set hive.execution.mode = auto");
{code}
hive.execution.mode=auto does not exist. The value is container. Can we refer
to the constants in HiveConf - in case the values change.
{code}
throw new SemanticException("Llap mode is set to all but cannot run work in
llap mode. "
+ "Set hive.llap.execution.mode = auto or set hive.execution.mode =
auto");
{code}
extra can.
In terms of the exception - this changes the current behaviour for mode=ALL.
Should we add a new mode which is ALL_ALLOW_FALLBACK or some such to retain
current behaviour for ALL.
> Improve logging in llap decider for llap
> ----------------------------------------
>
> Key: HIVE-13342
> URL: https://issues.apache.org/jira/browse/HIVE-13342
> Project: Hive
> Issue Type: Bug
> Components: llap
> Affects Versions: 2.1.0
> Reporter: Vikram Dixit K
> Assignee: Vikram Dixit K
> Attachments: HIVE-13342.1.patch
>
>
> Currently we do not log our decisions with respect to llap. Are we running
> everything in llap mode or only parts of the plan. We need more logging.
> Also, if llap mode is all but for some reason, we cannot run the work in llap
> mode, fail and throw an exception advise the user to change the mode to auto.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
