[
https://issues.apache.org/jira/browse/HIVE-13413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229445#comment-15229445
]
Prasanth Jayachandran commented on HIVE-13413:
----------------------------------------------
Mostly looks good
Some minor comments:
1) // TODO Add additional information such as #executors, container size, etc
Create a follow-up? I guess at this point this tool is just used as health
check/status of daemons. Per daemon configurations are obtained via JMX?
2) daemon webaddress/status page currently shows Error 404. Is that part of
this jira or another?
3) populateAppStatusFromLlapRegistry(). do we need to create new Configuration
object? reuse already created object?
4) llapExtraInstances.add(llapInstance); This line add nulls to the list right?
I don't see it used anywhere other than logging. use boolean instead?
5) nit: remove deadcode. // String nmUrl = (String)
containerParams.get("hostUrl");
6) wow. Map<String, Map<String, Map<String, Object>>> :)
> add a llapstatus command line tool
> ----------------------------------
>
> Key: HIVE-13413
> URL: https://issues.apache.org/jira/browse/HIVE-13413
> Project: Hive
> Issue Type: Improvement
> Components: llap
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: HIVE-13413.01.patch, appComplete, invalidApp,
> oneContainerDown, running, starting
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
