[
https://issues.apache.org/jira/browse/HIVE-13413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siddharth Seth updated HIVE-13413:
----------------------------------
Attachment: HIVE-13413.02.patch
Thanks for the review. Updated patch attached.
bq. Create a follow-up? I guess at this point this tool is just used as health
check/status of daemons. Per daemon configurations are obtained via JMX?
Done
bq. daemon webaddress/status page currently shows Error 404. Is that part of
this jira or another?
This is being added in HIVE-13398
bq. populateAppStatusFromLlapRegistry(). do we need to create new Configuration
object? reuse already created object?
Creating a new instance, since we're modifying a field to set the instance
name. Don't want to modify the original configuration used by the class.
bq. llapExtraInstances.add(llapInstance); This line add nulls to the list
right? I don't see it used anywhere other than logging. use boolean instead?
This was not supposed to be adding LlapInstances. Changed to add containerId.
While that's not used - it could be useful for logging in the future.
bq. nit: remove deadcode. // String nmUrl = (String)
containerParams.get("hostUrl");
Done
bq. wow. Map<String, Map<String, Map<String, Object>>>
That was painful to deal with :(
> add a llapstatus command line tool
> ----------------------------------
>
> Key: HIVE-13413
> URL: https://issues.apache.org/jira/browse/HIVE-13413
> Project: Hive
> Issue Type: Improvement
> Components: llap
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: HIVE-13413.01.patch, HIVE-13413.02.patch, appComplete,
> invalidApp, oneContainerDown, running, starting
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
