[
https://issues.apache.org/jira/browse/HIVE-11793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243911#comment-15243911
]
Eugene Koifman commented on HIVE-11793:
---------------------------------------
[~wzheng]
1. I'm not sure it's OK to just change method signatures on
HiveMetaStoreClient. I think this is considered public API. Same for
IMetaStoreClient.
2. TxnHandler.showLocks(): if dbName == null, should it add "hl_db=default"
in the WHERE?
3. dbtxnmgr_showlocks.q: it seems a bit limited since there are no locks in the
system. TestDbTxnManager2.java has some examples how you can create some locks
for testing. patch in HIVE-13395 has more/better examples also in
TestDbTxnManager2. This is not critical
> SHOW LOCKS with DbTxnManager ignores filter options
> ---------------------------------------------------
>
> Key: HIVE-11793
> URL: https://issues.apache.org/jira/browse/HIVE-11793
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Wei Zheng
> Priority: Minor
> Attachments: HIVE-11793.1.patch, HIVE-11793.2.patch
>
>
> https://cwiki.apache.org/confluence/display/Hive/Locking and
> https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-ShowLocks
> list various options that can be used with SHOW LOCKS, e.g. <TABLE>
> When ACID is enabled, all these options are ignored and a full list is
> returned.
> (also only ext lock id is shown, int lock id is not).
> see DDLTask.showLocks() and TxnHandler.showLocks()
> requires extending ShowLocksRequest which is a Thrift object
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
