[jira] [Commented] (HIVE-13615) nomore_ambiguous_table_col.q is failing on master

[Hari Sankar Sivarama Subramaniyan (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-13615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262893#comment-15262893
 ] 

Hari Sankar Sivarama Subramaniyan commented on HIVE-13615:
----------------------------------------------------------

[~ashutoshc] Here is the problem:
{code}
identifier
    :
    Identifier
    | nonReserved -> Identifier[$nonReserved.text]
    // If it decides to support SQL11 reserved keywords, i.e., 
useSQL11ReservedKeywordsForIdentifier()=false,
    // the sql11keywords in existing q tests will NOT be added back.
    | {useSQL11ReservedKeywordsForIdentifier()}? 
sql11ReservedKeywordsUsedAsIdentifier -> 
Identifier[$sql11ReservedKeywordsUsedAsIdentifier.text]
    ;
{code}

If you at the grammar files we use "Identifier" and "identifier" 
interchangeably. I think we should use "identifier" everywhere except for the 
above defiinition.

cc-ing [~pxiong] 

Thanks
Hari

> nomore_ambiguous_table_col.q is failing on master
> -------------------------------------------------
>
>                 Key: HIVE-13615
>                 URL: https://issues.apache.org/jira/browse/HIVE-13615
>             Project: Hive
>          Issue Type: Test
>          Components: Parser
>    Affects Versions: 2.1.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>
> Fails with:
> FAILED: ParseException line 3:9 cannot recognize input near 'src' 'key' 
> 'INSERT' in from source 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)