[
https://issues.apache.org/jira/browse/HIVE-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277151#comment-15277151
]
Eugene Koifman commented on HIVE-13249:
---------------------------------------
I think maxOpenTxns numOpenTxns tooManyOpenTxns should all be volatile since
they are accessed by different threads
I would make LOG.warn("Transaction database not properly configured ... be
"error"
You don't need to add "OpenTxnsCounter" - nothing bad can happen if
AcidOpenTxnsCounterService runs in parallel - it's just a count(*) query
Because TxnHandler exists in standalone metastore (e.g. HS2), you probably need
to start AcidOpenTxnsCounterService from TxnHandler.setConf() but such that
there is only 1 instance of AcidOpenTxnsCounterService per JVM
> Hard upper bound on number of open transactions
> -----------------------------------------------
>
> Key: HIVE-13249
> URL: https://issues.apache.org/jira/browse/HIVE-13249
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Affects Versions: 2.0.0
> Reporter: Wei Zheng
> Assignee: Wei Zheng
> Attachments: HIVE-13249.1.patch, HIVE-13249.2.patch,
> HIVE-13249.3.patch, HIVE-13249.4.patch, HIVE-13249.5.patch,
> HIVE-13249.6.patch, HIVE-13249.7.patch
>
>
> We need to have a safeguard by adding an upper bound for open transactions to
> avoid huge number of open-transaction requests, usually due to improper
> configuration of clients such as Storm.
> Once that limit is reached, clients will start failing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
