[
https://issues.apache.org/jira/browse/HIVE-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277413#comment-15277413
]
Eugene Koifman commented on HIVE-13458:
---------------------------------------
I think queryId should be set to null in stopHeartbeat() just like
heartbeatTask
Shouldn't acquireLocksWithHeartbeatDelay() do
ctx.setHeartbeater(startHeartbeat()); ? Or perhaps better, this and make
acquireLocks(QueryPlan plan, Context ctx, String username) call
acquireLocksWithHeartbeatDelay()
Why did the 2 .q files change? They don't seem to be related to any of the
changes
> Heartbeater doesn't fail query when heartbeat fails
> ---------------------------------------------------
>
> Key: HIVE-13458
> URL: https://issues.apache.org/jira/browse/HIVE-13458
> Project: Hive
> Issue Type: Bug
> Components: Transactions
> Affects Versions: 2.1.0
> Reporter: Wei Zheng
> Assignee: Wei Zheng
> Attachments: HIVE-13458.1.patch, HIVE-13458.2.patch,
> HIVE-13458.3.patch, HIVE-13458.4.patch, HIVE-13458.5.patch,
> HIVE-13458.6.patch, HIVE-13458.7.patch, HIVE-13458.8.patch
>
>
> When a heartbeat fails to locate a lock, it should fail the current query.
> That doesn't happen, which is a bug.
> Another thing is, we need to make sure stopHeartbeat really stops the
> heartbeat, i.e. no additional heartbeat will be sent, since that will break
> the assumption and cause the query to fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
