[ 
https://issues.apache.org/jira/browse/HIVE-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297363#comment-15297363
 ] 

Pengcheng Xiong commented on HIVE-13646:
----------------------------------------

Hi [~ekoifman] and [~wzheng], thanks for your work to make 
hive.optimize.sort.dynamic.partition compatible with ACID tables. However, it 
seems that extra work is needed to make them work together. After I discuss 
with [~prasanth_j], this problem sounds serious as we are getting wrong #rows 
and also wrong total data size which will result in correctness issue and also 
performance issue. Could you guys take a look at HIVE-13773? I have attached a 
t.q and a wrong t.q.out and it can be easily repro on master. If I revert the 
patch in this JIRA, it works fine. Thanks. also ccing [~ashutoshc].

> make hive.optimize.sort.dynamic.partition compatible with ACID tables
> ---------------------------------------------------------------------
>
>                 Key: HIVE-13646
>                 URL: https://issues.apache.org/jira/browse/HIVE-13646
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>            Priority: Critical
>             Fix For: 1.3.0, 2.1.0
>
>         Attachments: HIVE-13646.2.patch, HIVE-13646.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> HIVE-8875 disabled hive.optimize.sort.dynamic.partition for ACID queries.
> dynamic inserts are common in ACID and this leaves users with few options if 
> they are seeing OutOfMemory errors due to too many writers.
> hive.optimize.sort.dynamic.partition sorts data by partition col/bucket 
> col/sort col to ensure each reducer only needs 1 writer.
> Acid requires data in each bucket file to be sorted by ROW__ID and thus 
> doesn't allow end user to determine sorting.
> So we should be able to support hive.optimize.sort.dynamic.partition with
> sort on partition col/bucket col/ROW__ID 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to