[ 
https://issues.apache.org/jira/browse/HIVE-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304993#comment-15304993
 ] 

Wei Zheng commented on HIVE-11956:
----------------------------------

1. You need to make changes to newFormatSchema in ShowLocksDesc as well for the 
additional column added for show locks
2. For the modified methods in HiveEndPoint, there's "throws IOException" in 
comment header which isn't thrown by the methods
3. In TestDbTxnManager2.testShowLocksAgentInfo(), do you mean 
txnMgr.acquireLocks(driver.getPlan(), ctx, "XYZ");
4. Unused import org.apache.hadoop.hive.metastore.txn.TxnStore in 
TestStreaming.java
5. I guess you meant to use agentInfo in TestStreaming.testBucketing() and 
testFileDump()



> SHOW LOCKS should indicate what acquired the lock
> -------------------------------------------------
>
>                 Key: HIVE-11956
>                 URL: https://issues.apache.org/jira/browse/HIVE-11956
>             Project: Hive
>          Issue Type: Improvement
>          Components: CLI, Transactions
>    Affects Versions: 0.14.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>            Priority: Critical
>         Attachments: HIVE-11956.patch
>
>
> This can be a queryId, Flume agent id, Storm bolt id, etc.  This would 
> dramatically help diagnosing issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to