[
https://issues.apache.org/jira/browse/HIVE-13931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319087#comment-15319087
]
Sushanth Sowmyan commented on HIVE-13931:
-----------------------------------------
I was about to state that the above test failiures had nothing to do with this
patch, but I see that some golden files now have additional entries as follows:
{noformat}
19,21d18
< at
com.zaxxer.hikari.pool.ProxyPreparedStatement.executeUpdate(ProxyPreparedStatement.java:61)
< at
com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeUpdate(HikariProxyPreparedStatement.java)
< #### A masked pattern was here ####
25,27d21
< at
com.zaxxer.hikari.pool.ProxyPreparedStatement.executeUpdate(ProxyPreparedStatement.java:61)
< at
com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeUpdate(HikariProxyPreparedStatement.java)
< #### A masked pattern was here ####
{noformat}
This is annoying. This means that either we leak the Hikari exception
signatures into the q.out files(definitely not to my liking), or we add an
additional masking pattern for this (not to my liking either, but this is
better)
Although it is funny that these weren't reported with the last test run. I will
verify with local runs.
I will look into this further and update as needed. [~sershe],
thoughts/preferences on approach?
> Add support for HikariCP and replace BoneCP usage with HikariCP
> ---------------------------------------------------------------
>
> Key: HIVE-13931
> URL: https://issues.apache.org/jira/browse/HIVE-13931
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: Sushanth Sowmyan
> Assignee: Sushanth Sowmyan
> Attachments: HIVE-13931.2.patch, HIVE-13931.patch
>
>
> Currently, we use BoneCP as our primary connection pooling mechanism
> (overridable by users). However, BoneCP is no longer being actively
> developed, and is considered deprecated, replaced by HikariCP.
> Thus, we should add support for HikariCP, and try to replace our primary
> usage of BoneCP with it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
