[
https://issues.apache.org/jira/browse/HIVE-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322649#comment-15322649
]
Sergio Peña commented on HIVE-13964:
------------------------------------
Thanks [~ayousufi].
1. Could you add one space between braces and parenthesis? We should follow the
code convention we see along the Hive code.
{code}
if(propertyFile != null){
dispatch("!properties " + propertyFile);
}
{code}
2. When a pass the --property-file without a parameter, I just see the help
message displayed, but it does not show the error or why it failed. Can we add
that too?
{noformat}
$ beeline --property-file
Usage: java org.apache.hive.cli.beeline.BeeLine
-u <database url> the JDBC URL to connect to
...
{noformat}
3. Should we fail the execution of beeline if the file passed does not exist?
[~xuefuz] What do you think about this? I think we should exit from beeline if
a parameter like this is passed. If users have this parameter in a script, they
will never know that a file does not exist, and they will continue executing
their queries without noticing.
{noformat}
$ beeline --property-file
a (No such file or directory)
Beeline version 2.2.0-SNAPSHOT by Apache Hive
beeline>
{noformat}
> Add a parameter to beeline to allow a properties file to be passed in
> ---------------------------------------------------------------------
>
> Key: HIVE-13964
> URL: https://issues.apache.org/jira/browse/HIVE-13964
> Project: Hive
> Issue Type: New Feature
> Components: Beeline
> Affects Versions: 2.0.1
> Reporter: Abdullah Yousufi
> Assignee: Abdullah Yousufi
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: HIVE-13964.01.patch
>
>
> HIVE-6652 removed the ability to pass in a properties file as a beeline
> parameter. It may be a useful feature to be able to pass the file in is a
> parameter, such as --property-file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
